Skip to content

Fix Unban button failing to pardon users

Wout Bouckaert requested to merge bugfix/unban into dev

What does this MR do and why?

Resolves issue on player management panel that was adding a trailing space to the pardon command. Removes trailing space that was causing error.

Old command issued to server: pardon username (with trailing space)

New command issued to server: pardon username

Resolves issue #306 (closed)

Screenshots or screen recordings

Pre-fix:

(from issue 306)

grafik.png

Post-fix:

firefox_2023-11-11_12-36-24.jpg

How to set up and validate locally

  1. Setup vanilla server in Crafty.
  2. Join server to appear in player management panel in Crafty.
  3. Ban player in player management panel.
  4. Un-ban player in player management panel.

The command should be issued correctly to the server and the player should be able to join.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Have you checked this doesn't interfere/conflict/duplicate someone elses work?
  • Have you fully tested your changes?
  • Have you resolved any lint issues?
  • Have you assigned a reviewer?
  • Have you applied correct labels?
Edited by Iain Powrie

Merge request reports