Skip to content
Snippets Groups Projects

Fix notifications not showing up/being reset

Merged Andrew requested to merge bugfix/notification-reset into dev

What does this MR do and why?

Fix notifications being reset when we fail to reach craftycontrol.com The proposed solution is to catch the request exception and return falsey. When we get a falsey response from getAnnoucements we will return a 424 dependency error with a description that we could not get notifications from craftycontrol.com

Fix #298 (closed)

Screenshots or screen recordings

image

How to set up and validate locally

I was only able to recreate this bug by spamming refresh on the dashboard.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Have you checked this doesn't interfere/conflict/duplicate someone elses work?
  • Have you fully tested your changes?
  • Have you resolved any lint issues?
  • Have you assigned a reviewer?
  • Have you applied correct labels?
Edited by Andrew

Merge request reports

Pipeline #1057052652 passed

Pipeline passed for ec137db1 on bugfix/notification-reset

Merged by Iain PowrieIain Powrie 1 year ago (Nov 1, 2023 12:52am UTC)

Loading

Pipeline #1057075345 passed

Pipeline passed for 833cbaf7 on dev

Deployed to produ‎ction‎ 1 year ago
Deployed to devel‎opment‎ 1 year ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading