Fix notifications not showing up/being reset
What does this MR do and why?
Fix notifications being reset when we fail to reach craftycontrol.com The proposed solution is to catch the request exception and return falsey. When we get a falsey response from getAnnoucements we will return a 424 dependency error with a description that we could not get notifications from craftycontrol.com
Fix #298 (closed)
Screenshots or screen recordings
How to set up and validate locally
I was only able to recreate this bug by spamming refresh on the dashboard.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
Have you checked this doesn't interfere/conflict/duplicate someone elses work? -
Have you fully tested your changes? -
Have you resolved any lint issues? -
Have you assigned a reviewer? -
Have you applied correct labels?
Edited by Andrew