Skip to content
Snippets Groups Projects

Fix Backup Restore/Schedules, Backup button

Merged Fix Backup Restore/Schedules, Backup button
bugfix/backups into dev
Merged Andrew requested to merge bugfix/backups into dev

What does this MR do and why?

Backups currently have two bugs:

  1. Backup status bar does not always show up after a refresh
  2. Backup schedules are retained in the DB, but not in the jobstore (https://gitlab.com/crafty-controller/crafty-4/-/issues/280)
  3. Backup restore does not work due to method name changes in remote-comms2.

This MR resolves both these issues.

How to set up and validate locally

Problem 1:

  1. Start a backup on a high-performance device. It is possible the page will load before the status shows up.

Problem 2:

  1. Create a server
  2. Create a scheduled task for the server
  3. Restore the backup. The schedule will appear in the list, but will never fire.

Problem 3:

  1. Try to create a backup then restore it on the dev branch.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Have you checked this doesn't interfere/conflict/duplicate someone elses work?
  • Have you fully tested your changes?
  • Have you resolved any lint issues?
  • Have you assigned a reviewer?
  • Have you applied correct labels?
Edited by Andrew

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply