Skip to content
Snippets Groups Projects

Optimize player management page

Merged Optimize player management page
refactor/players-management into dev
Merged Andrew requested to merge refactor/players-management into dev

What does this MR do and why?

  • Change page based on smaller displays.
  • Allow realtime stats updates
  • Crafty creates it's own internal cache so we are not loading a file everytime (minimize read/write on disk).

Resolves #243 (closed)

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Have you checked this doesn't interfere/conflict/duplicate someone elses work?
  • Have you fully tested your changes?
  • Have you resolved any lint issues?
  • Have you assigned a reviewer?
  • Have you applied correct labels?
Edited by Andrew

Merge request reports

Pipeline #903575669 passed

Stage: lint
Stage: test

Pipeline passed for 3755c194 on refactor/players-management

Merged by Iain PowrieIain Powrie 1 year ago (Jun 18, 2023 12:12pm UTC)

Loading

Pipeline #903583039 passed

Stage: lint
Stage: test
Stage: dev-deployment

Pipeline passed for ec7eede6 on dev

Deployed to produ‎ction‎ 1 year ago
Deployed to devel‎opment‎ 1 year ago

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Andrew added Bug Refactor labels

    added Bug Refactor labels

  • Andrew requested review from @Zedifus

    requested review from @Zedifus

  • Andrew assigned to @amcmanu3

    assigned to @amcmanu3

  • Andrew marked the checklist item Have you checked this doesn't interfere/conflict/duplicate someone elses work? as completed

    marked the checklist item Have you checked this doesn't interfere/conflict/duplicate someone elses work? as completed

  • Andrew marked the checklist item Have you fully tested your changes? as completed

    marked the checklist item Have you fully tested your changes? as completed

  • Andrew marked the checklist item Have you resolved any lint issues? as completed

    marked the checklist item Have you resolved any lint issues? as completed

  • Andrew marked the checklist item Have you assigned a reviewer? as completed

    marked the checklist item Have you assigned a reviewer? as completed

  • Andrew marked the checklist item Have you applied correct labels? as completed

    marked the checklist item Have you applied correct labels? as completed

  • Andrew marked this merge request as draft

    marked this merge request as draft

  • Andrew marked the checklist item Have you checked this doesn't interfere/conflict/duplicate someone elses work? as incomplete

    marked the checklist item Have you checked this doesn't interfere/conflict/duplicate someone elses work? as incomplete

  • Andrew marked the checklist item Have you fully tested your changes? as incomplete

    marked the checklist item Have you fully tested your changes? as incomplete

  • Andrew marked the checklist item Have you resolved any lint issues? as incomplete

    marked the checklist item Have you resolved any lint issues? as incomplete

  • Andrew marked the checklist item Have you assigned a reviewer? as incomplete

    marked the checklist item Have you assigned a reviewer? as incomplete

  • Andrew marked the checklist item Have you applied correct labels? as incomplete

    marked the checklist item Have you applied correct labels? as incomplete

  • Andrew added 1 commit

    added 1 commit

    • be518326 - Fix banned players formatting

    Compare with previous version

  • Andrew marked the checklist item Have you checked this doesn't interfere/conflict/duplicate someone elses work? as completed

    marked the checklist item Have you checked this doesn't interfere/conflict/duplicate someone elses work? as completed

  • Andrew marked the checklist item Have you fully tested your changes? as completed

    marked the checklist item Have you fully tested your changes? as completed

  • Andrew marked the checklist item Have you resolved any lint issues? as completed

    marked the checklist item Have you resolved any lint issues? as completed

  • Andrew marked the checklist item Have you assigned a reviewer? as completed

    marked the checklist item Have you assigned a reviewer? as completed

  • Andrew marked the checklist item Have you applied correct labels? as completed

    marked the checklist item Have you applied correct labels? as completed

  • Andrew marked this merge request as ready

    marked this merge request as ready

  • Andrew mentioned in issue #243 (closed)

    mentioned in issue #243 (closed)

  • Andrew changed the description

    changed the description

  • Iain Powrie mentioned in commit 3755c194

    mentioned in commit 3755c194

  • Iain Powrie added 1 commit

    added 1 commit

    Compare with previous version

  • Iain Powrie approved this merge request

    approved this merge request

  • Iain Powrie mentioned in commit ec7eede6

    mentioned in commit ec7eede6

  • Iain Powrie merged

    merged

  • Iain Powrie mentioned in merge request !598 (merged)

    mentioned in merge request !598 (merged)

Please register or sign in to reply