Skip to content

Managed config.json refactor

Andrew requested to merge refactor/config-json into dev

What does this MR do and why?

  • Json diff master config and user config.json to add/remove keys as necessary.

  • This will remove Config.json from the repo and create it on first launch. We have also added a guide on how to make one on boot to change the http and https ports should the user know there will be a conflict.

  • Remove cookie_secret and api_secret from config.json once and for all.

  • Add option in config.json to reset these values on the next boot. Once Crafty boots with that option it will set the option back to false in config.json

  • Add row to crafty_settings table on fresh install

  • Move api from inserting to updating in database so we don't end up with tons of rows once users start updating these keys.

Implements #153 (closed)

Need to figure out a good way to handle new installs. Should we continue to install with a conifg.json or add server port to defaults.json?

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Have you checked this doesn't interfere/conflict/duplicate someone elses work?
  • Have you fully tested your changes?
  • Have you resolved any lint issues?
  • Have you assigned a reviewer?
  • Have you applied correct labels?
Edited by Iain Powrie

Merge request reports