Skip to content

Make the WebSocket automatically reconnect.

What does this MR do and why?

Make the WebSocket automatically reconnect.

The WebSocket reconnects 5 seconds after the connection's closure. If the connection reconnection fails it will try to reconnect after another 5 seconds.

This is very important if the connection between Crafty and the client has a high chance of getting interrupted.

Screenshots or screen recordings

image

How to set up and validate locally

  1. Checkout on my branch
  2. Start Crafty
  3. Go to the dashboard logged in
  4. Stop the server for like 20 seconds
  5. Start the server again and experience automatic WebSocket reconnection

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Have you checked this doesn't interfere/conflict/duplicate someone elses work?
  • Have you fully tested your changes?
  • Have you resolved any lint issues?
  • Have you assigned a reviewer?
  • Have you applied correct labels?
Edited by Lukas ‎‎‎‎

Merge request reports

Loading