Skip to content

Only remove manifest and hash file if they exist. Add OSError detection to jar deletion.

Wout Bouckaertrequested to merge
bugfix/cleanup-errors into dev

What does this MR do and why?

  • Move deletion of manifest and manifest hash file out of try/except block for jar file deletion.
  • Check if manifest and manifest file exist before attempting to delete them.
  • Add OSError to try/except for jars deletion as that is one of the errors it can throw per documentation here.

Resolves #10 (closed)

How to set up and validate locally

No program flow changes. Added more verbose logging and checks before existing actions. Tested on local dev instance of Big Bucket.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Have you checked this doesn't interfere/conflict/duplicate someone elses work?
  • Have you fully tested your changes?
  • Have you resolved any lint issues?
  • Have you assigned a reviewer?
  • Have you applied correct labels?

Merge request reports