Skip to content

ENH: Use a vector to store symbols.

Alexander Tygesen requested to merge symb_with_numbers_vector into master

Using a vector makes it a bit clearer how things are being managed and accessed.

Basically, the internal symb_ids is now std::vector<unsigned int>, rather than a pointer to an array of integers. I also made it use .at() (i.e. bounds checking) in non-speed critical functions, just for safety. This also makes memory management easier, as we no longer have to remember to de-allocate ourselves. (In general, I'm not a big fan of the new MyType[N] construction)

(Also, editor wanted to make several minor style changes I see..)

Merge request reports