Improvements Failed Contract Distributions
Todo
-
Rename db table distributions
->failed_distributions
-
Rename db columns
retries
->attempts
last_retry_at
->last_attempt_at
next_retry_at
->next_attempt_at
This makes more sense when you look from the UI, where we also display 'attempts' on the Distribution detail page. RenameContractDistributionService
->DistributionService
since it distributes both contracts and signaturesMove exponential backoff logic from thePeerCommunicationService
to theContractDistributionService
. TheContractDistributionService
can use thePeerCommunicationService
to send the contracts. TheDistributionService
can have better readable method names then. Eg.DistributeContract
,DistributeSignature
instead ofUpdateWithLastAttempt
orUpdateNewAttempt
.-
Disable manual resend buttons when next_retry_at
is not empty -
Review translations for the resend distribution confirmation modal -
Also display time in the UI for the next attempt at (only the date is not sufficient enough) Prevent multiple concurrent retries for the same distribution. Introduce lock?
Issue: #217 (closed)
Edited by Niels