Skip to content

Implement tests from the AcceptContract Test Suite

Niels requested to merge review/89-content-hash into main

Related MR for the FSC Standard: commonground/standards/fsc!148 (merged)

  • We're missing error codes in the FSC standard. See TODO's in the assertions.
  • Creation of the content hash should be verified, so we can use this function throughout our domain
  • How should we assert the creation of the signatures? Since the return value seems not to be idempotent. Should we introduce an extra function to validate its correctness?
  • If these tests are ok, we can reuse the structure for the Reject & Revoke scenario's.
  • Add error code to standard: unknown hash algorithm

Todo in a follow up MR:

  • Verify the Content Hash of the URL path and check if it matches the Content Hash of the content in the request body. Adjust the test accordingly.
  • Re-use the Accept Contract tests for Revoke and Reject

Issue: #89 (closed)

Edited by Niels

Merge request reports