Combat click-drag override preference

Changelog

🆑 Vanagandr

rscadd: Added a combat click-drag override preference. When this is set and you're on disarm or harm intent, depressing the mouse triggers a click immediately even if you hold it down. Clicking something in your inventory, yourself, or an ally behaves normally, unless you're a xeno clicking with an empty hand. This applies to all clicks, including shooting and middle-mouse abilities.

tweak: The game will now only process one click per mouse-down. This shouldn't have any practical effect on the game aside from stopping the above from triggering extra clicks.

rscadd: Added mentorhelp default reply for above pref.

/🆑

Details

When clicking while moving the mouse, Byond sometimes detects it as a click-and-drag attempt and prevents the click from taking effect, even if the button was only held down for an instant.

A side effect of how this is done is that sometimes byond tries to trigger a click of its own when the LMB is released, so there's a var and check to stop that from double-clicking.

This is an issue that has caused a lot of frustration for quite a few people, and can be seen in action clips posted on the Discord and complained about, directly ('clickdrag') or indirectly ('almost had him but fucking byond ate all my PBs') by both marines and xenos almost every day.

Compared to the closed clickdrag MR, this applies to all clicks, including melee attacks and ability activations, rather than just guns. It's also safer/more maintainable in that it just calls the click proc directly, instead of duplicating half the checks.

The one-click-per-mousedown thing is cleaner than the previous method I used here, and shouldn't have any practical effect.

Related Issues

Closes