Skip to content

68 Image list re-directs to create account screen on date select change to time before time

CD Cabrera requested to merge cdcabrera/frontigrade:68-images-view into master

What's included

  • fix for showing date and filters active on images view
    • updated account view, account images views layout
    • minor fix for account, account images views and multiple service calls
    • clean up filter reducer, added date clear
    • relocated get account API response to account reducer
    • copy and spacing updates, issue #69 (closed)
  • unit tests
    • updated unit tests and snapshots, related fixes
    • fix build dotenv values not firing in context
    • updated mock server package for delayed response testing

Notes

  • split the commits between actual fixes and unit tests

How to test

The mock dev setup can be used to help a quick confirmation.

  1. Clone the updates locally, then
  2. From the terminal, within the repo context, run $ yarn start
  3. You may need to log in, do so, if not you should see something similar to this layout

Related to 68

The QE review setup can be used to help a quick confirmation. (you'll need a login)

  1. Clone the updates locally, then
  2. From the terminal, within the repo context, run $ yarn start:review
  3. You may need to log in, do so, if not you should see something similar to the below layout once you click and navigate to the detail view

If you want to use the mock dev server to test you'll need to remove some static lines to see the expected result

  1. Clone the updates locally, then
  2. From the terminal, within the repo context, run $ yarn start
  3. Delete lines 199 - 243 of the accountServices.js mock annotation
  4. You may need to log in, do so, if not you should see something similar to the below layout once you click and navigate to the detail view

Screen_Shot_2018-08-16_at_9.56.13_PM

Spacing related to 69

The mock dev setup can be used to help a quick confirmation.

  1. Clone the updates locally, then
  2. From the terminal, within the repo context, run $ yarn start
  3. You may need to log in, do so, if not you should see something similar to the below layout once you click through the add account wizard

Screen_Shot_2018-08-16_at_9.54.02_PM

Updates issue

updates #68 (closed) #69 (closed)

Edited by CD Cabrera

Merge request reports