Skip to content

54 Change dashboard view to limit on selected account

CD Cabrera requested to merge cdcabrera/frontigrade:54-account-detail into master

What's included

  • dotenv API endpoint
  • apiConstants expanded
  • router component and testing updates
  • list styling for columns, breadcrumbs
  • global redux filters for accountView, accountImagesView, viewToolbar
  • rename from accountDetail to accountImages
  • accountImages(View) component expanded
  • update accountServices, getAccountImages service mock
  • redux for accountImages, accountImagesView, accountActions
  • combined toolbar into accountView, accountImagesView, viewToolbar
  • unit tests and snapshots updated
  • hide the RHOCP label per discussion, updated snapshots

Notes

  • Name filtering is currently not available, the field is hidden using an empty array in the filter fields list
  • The RHOCP label, shown below in the ideal screenshot, is temporarily hidden with CSS
  • Immediate review changes @bclarhk @erezende
    • dashes when an image list item is something other than a number
    • seconds tooltip, on hover for images' hours. Since the UI is asked to calc hours from seconds lets be open about it
    • breadcrumbs, avoid placing the word "account" in front of an "account" unless it's just an ID
  • FUTURE, next round @bclarhk
    • evaluate shifting views to "account" when "add an account" wizard is activated

How to test

The mock dev setup can be used to help a quick confirmation.

  1. Clone the updates locally, then
  2. From the terminal, within the repo context, run $ npm start
  3. You may need to log in, do so, if not you should see something similar to the below layout

Example

More ideal version

Screen_Shot_2018-08-03_at_12.29.30_PM

What's actually there

Aug-03-2018_12-31-53

Updates issue/story

Updates #54 (closed)

Edited by CD Cabrera

Merge request reports