Skip to content

34 Edit cloud account name from dashboard

CD Cabrera requested to merge cdcabrera/frontigrade:34-edit-account-name into master

What's included

accountEditModal plus support updates

  • add accountEditModal component
  • add redux reducers, actions, constants for accountEditModal
  • detect "null" when displaying account summary responses
  • router component, additional props for views
  • add base accountDetailView component
  • API level annotations for future work
  • add updateAccountField service call for patch
  • unit test updates

chores, fixes

chore naming for apiTypes

  • update apiTypes naming scheme

fix update login checks


  • update basic login check instead of using null
  • allow editing of restored email when "remember email" is checked

fix #60 (closed) added accounts not showing up

  • added dispatch for updating accounts

Notes

  • It appears there are API preflight errors around using patch, instead we went ahead and used put in order to avoid being blocked. Will open a bug accordingly. The fix is a separate commit on purpose. Screen_Shot_2018-07-30_at_4.37.33_PM

How to test

The mock dev setup can be used to help a quick confirmation.

  1. Clone the updates locally, then
  2. From the terminal, within the repo context, run $ npm start
  3. You may need to log in, do so, if not you should see something similar to the below layout.
    • The mock server will not display updates to properties.

Example

Success example

Jul-30-2018_17-31-40

Error example

Jul-30-2018_16-25-25

Updates issue/story

Updates #34 (closed) #60 (closed)

Edited by CD Cabrera

Merge request reports