withTaskId and withShared pure
What does this MR do?
Make withShared
and friends pure.
This required cleaning up of local shares to be done at the engine level (and not when handling a DestroyEvent
in the task).
Related issues
Changes to public APIs
n.a.
Author's checklist (required)
See CONTRIBUTING.md for the rationale behind these items:
-
The commit history does not contain merges (use git rebase -i master
if it does) -
Intermediate commits compile (use git rebase -i master
if not) -
Newly added code follows the Platform code style -
Newly added code is documented -
If bugs have been solved, tests have been added -
Appropriate types have been used, especially in APIs -
If efficiency is part of the acceptance criteria of the issue, a benchmark is provided -
A changelog entry has been added if required. See CONTRIBUTING.md