Skip to content

Check that all sources are targeted

Nikolai Kondrashov requested to merge spbnick/pipeline-definition:check_all_sources_are_targeted into main

In addition to checking whether we have any targeted tests, also check that all changed sources (if any) have been targeted by tests. Store the result in the all_sources_targeted rc variable, as such:

  • -1 - no patches were provided, or no (eligible) sources were found among changed files;
  • 1 - all changed sources were targeted;
  • 0 - some or all changed sources were untargeted.

Output the list of untargeted sources to the log (in yellow), in the latter case.

Rename the .setup-targeted-test section to just .setup-targeted, since it also deals with targeted sources now.

NOTE: I made handling of missing sources for all_sources_targeted match the one for targeted_sources. I.e. we set it to -1, when the patches didn't contain any (eligible) sources, even if we provided the former. However, we might have just as well used 1 in that case, since "yeah, we targeted all zero sources". Just pointing it out, take your pick 😁

Requires datadefinition!96 (merged)

Concerns #112 (closed)

Edited by Nikolai Kondrashov

Merge request reports