Skip to content

drm/nouveau/kms/nve4-nv108: Don't advertise 256x256 cursor support yet

Hans de Goede requested to merge jwrdegoede/kernel-ark:fedora-5.11-kepler-cursor-fix into fedora-5.11

This fixes the cursor misrendering which lots of users have been complaining about, see: https://bugzilla.redhat.com/show_bug.cgi?id=1941291 and the 4 bugs which I've marked as duplicates.

While Kepler does technically support 256x256 cursors, it turns out that in order for us to use these correctly we need to make sure that the cursor plane uses a ctxdma that is set to use small (4K)/large (128K) pages - whichever is applicable to the given cursor surface.

Right now however, we share the main kmsVramCtxDma that is used for all but the ovly plane which defaults to small pages - resulting in artifacts when we use 256x256 cursor surfaces. So until we teach nouveau to use a separate ctxdma for the cursor, let's just stop advertising 256x256 cursors by default - which should fix the issues that users were seeing.

Coincidentally - this is also why small ovlys don't work on Kepler: the ctxdma we use for ovlys is set to large pages.

Changes since v2:

  • Fix comments and patch description

Signed-off-by: Lyude Paul lyude@redhat.com Fixes: d3b2f0f7 ("drm/nouveau/kms/nv50-: Report max cursor size to userspace") Cc: stable@vger.kernel.org # v5.11+

Merge request reports