Skip to content
Snippets Groups Projects

redhat: add initial support for centos stream dist-git sync on Makefiles

Merged Herton R. Krzesinski requested to merge hertonrk-rh/kernel-ark:centos-intro into os-build
All threads resolved!
This change introduces some initial centos stream support, mainly what's
needed for a dist-git sync. The dist-git sync is initially proposed to
be a fork + merge request model, and thus we need some changes for the
Makefiles. I also dropped IS_FEDORA variable, and replace it with
DISTRO, which can have either "fedora" or "centos" (and could be set
later to "rhel" or anything else if needed through the code).
    
While at it, I also fixed the default RHPKG_BIN to rhpkg instead of
rhpkg-sha512 in the default RHEL case, the former was a wrapper for
the sha512 transition on dist-git at RHEL 8 time and is not needed
anymore, it is now deprecated and will be removed from rhpkg.
    
Example of a dist-git sync with new centos dist-git:
make DIST=".el9" GL_DISTGIT_USER=<gitlab user> BUILDID="" RHDISTGIT_BRANCH=c9s dist-git
    
Signed-off-by: Herton R. Krzesinski <herton@redhat.com>
Edited by Herton R. Krzesinski

Merge request reports

Merge request pipeline #273516174 passed

Pipeline: cki-trusted-contributors

#273516177

    Merge request pipeline passed for fc13ea49

    Approved by

    Merged by Patrick TalbertPatrick Talbert 4 years ago (Mar 23, 2021 1:29pm UTC)

    Merge details

    • Changes merged into os-build with 9c7b69a0.
    • Deleted the source branch.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Jan Stancek
  • Jan Stancek
  • Justin M. Forbes approved this merge request

    approved this merge request

  • Acked-by: Justin Forbes jforbes@fedoraproject.org (via approve button)

  • added 1 commit

    • df44f02b - redhat: add initial support for centos stream dist-git sync on Makefiles

    Compare with previous version

  • Herton R. Krzesinski resolved all threads

    resolved all threads

    • Resolved by Patrick Talbert

      @hertonrk-rh

      I still have folks who try to build kernel-ark for rhel8 using 'make dist-brew'. The defaults seem to be DISTRO=centos. Any thoughts on how this would work for rhel-8?

      Could you locally run a 'make dist-self-test'. I am curious to see if that catches anything. Not sure if it passes 100% yet. But there are some tests that try to run a few scenarios using DIST to make sure we didn't break a fedora workflow.

      Cheers, Don

  • added 1 commit

    • fc13ea49 - redhat: add initial support for centos stream dist-git sync on Makefiles

    Compare with previous version

  • Herton R. Krzesinski resolved all threads

    resolved all threads

  • @jstancek - any final concerns?

    the code is restricted to 'centos' distro so it won't get in the way. I will ack it for now.

  • Don Zickus approved this merge request

    approved this merge request

  • Acked-by: Don Zickus dzickus@redhat.com (via approve button)

  • added Acks::redhatOK label and removed Acks::redhatNeedsReview label

  • Fine by me. Acked-by: Jan Stancek jstancek@redhat.com

  • CKI KWF Bot added AcksOK label and removed AcksNeedsReview label

    added AcksOK label and removed AcksNeedsReview label

  • Patrick Talbert resolved all threads

    resolved all threads

  • Patrick Talbert mentioned in commit 9c7b69a0

    mentioned in commit 9c7b69a0

  • Please register or sign in to reply
    Loading