[redhat] New configs in drivers/gpio
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_GPIO_HISI:
Say Y or M here to build support for the HiSilicon GPIO controller driver GPIO block. This GPIO controller support double-edge interrupt and multi-core concurrent access.
Symbol: GPIO_HISI [=n] Type : tristate Defined at drivers/gpio/Kconfig:301 Prompt: HiSilicon GPIO controller driver Depends on: GPIOLIB [=y] && HAS_IOMEM [=y] && (ARM64 [=y] && ACPI [=y] || COMPILE_TEST [=n]) Location: -> Device Drivers -> GPIO Support (GPIOLIB [=y]) -> Memory mapped GPIO drivers Selects: GPIO_GENERIC [=m] && GPIOLIB_IRQCHIP [=y]
Cc: Brian Masney bmasney@redhat.com Cc: Mark Salter msalter@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org
Merge request reports
Activity
added Configuration label
added AcksNeedsReview label
David Arcari darcari@redhat.com commented via email:
On 12/18/20 2:33 AM, GitLab Bridge on behalf of redhat-patchlab wrote: > From: Fedora Kernel Team <kernel-team@fedoraproject.org> > > Hi, > > As part of the ongoing rebase effort, the following configuration > options need to be reviewed. > > As a reminder, the ARK configuration flow involves moving unreviewed > configuration options from the pending directory to the ark directory. > In the diff below, options are removed from the pending directory and > added to the ark hierarchy. The final options that need to be ACKed > are the files that are being added to the ark hierarchy. > > If the value for a file that is added should be changed, please reply > with a better option. > > CONFIG_GPIO_HISI: > > Say Y or M here to build support for the HiSilicon GPIO controller > driver GPIO block. > This GPIO controller support double-edge interrupt and multi-core > concurrent access. > > Symbol: GPIO_HISI [=n] > Type : tristate > Defined at drivers/gpio/Kconfig:301 > Prompt: HiSilicon GPIO controller driver > Depends on: GPIOLIB [=y] && HAS_IOMEM [=y] && (ARM64 [=y] && ACPI [=y] || COMPILE_TEST [=n]) > Location: > -> Device Drivers > -> GPIO Support (GPIOLIB [=y]) > -> Memory mapped GPIO drivers > Selects: GPIO_GENERIC [=m] && GPIOLIB_IRQCHIP [=y] > > --- > > Cc: Brian Masney <bmasney@redhat.com> > Cc: David Arcari <darcari@redhat.com> > Signed-off-by: Fedora Kernel Team <kernel-team@fedoraproject.org> > --- > .../configs/common/generic/CONFIG_GPIO_HISI | 1 + > .../pending-common/generic/CONFIG_GPIO_HISI | 21 ------------------- > 2 files changed, 1 insertion(+), 21 deletions(-) > create mode 100644 redhat/configs/common/generic/CONFIG_GPIO_HISI > delete mode 100644 redhat/configs/pending-common/generic/CONFIG_GPIO_HISI > > diff --git a/redhat/configs/common/generic/CONFIG_GPIO_HISI b/redhat/configs/common/generic/CONFIG_GPIO_HISI > new file mode 100644 > index 000000000000..dbf1059b9f24 > --- /dev/null > +++ b/redhat/configs/common/generic/CONFIG_GPIO_HISI > @@ -0,0 +1 @@ > +# CONFIG_GPIO_HISI is not set > diff --git a/redhat/configs/pending-common/generic/CONFIG_GPIO_HISI b/redhat/configs/pending-common/generic/CONFIG_GPIO_HISI > deleted file mode 100644 > index 297620d406ac..000000000000 > --- a/redhat/configs/pending-common/generic/CONFIG_GPIO_HISI > +++ /dev/null > @@ -1,21 +0,0 @@ > -# CONFIG_GPIO_HISI: > -# > -# Say Y or M here to build support for the HiSilicon GPIO controller > -# driver GPIO block. > -# This GPIO controller support double-edge interrupt and multi-core > -# concurrent access. > -# > -# Symbol: GPIO_HISI [=n] > -# Type : tristate > -# Defined at drivers/gpio/Kconfig:301 > -# Prompt: HiSilicon GPIO controller driver > -# Depends on: GPIOLIB [=y] && HAS_IOMEM [=y] && (ARM64 [=y] && ACPI [=y] || COMPILE_TEST [=n]) > -# Location: > -# -> Device Drivers > -# -> GPIO Support (GPIOLIB [=y]) > -# -> Memory mapped GPIO drivers > -# Selects: GPIO_GENERIC [=m] && GPIOLIB_IRQCHIP [=y] > -# > -# > -# > -# CONFIG_GPIO_HISI is not set > We need someone with ARM64 product knowledge to respond to this. Thanks, -DA
Resolved by Don Zickus=n is fine, but needs to be in .../generic/aarch64
Mark
- Last reply by Patrick Talbert
added No CCs label
David Arcari darcari@redhat.com commented via email:
On 12/22/20 4:12 AM, GitLab Bridge on behalf of redhat-patchlab wrote: > From: redhat-patchlab on gitlab.com > > Hi, > > As part of the ongoing rebase effort, the following configuration > options need to be reviewed. > > As a reminder, the ARK configuration flow involves moving unreviewed > configuration options from the pending directory to the ark directory. > In the diff below, options are removed from the pending directory and > added to the ark hierarchy. The final options that need to be ACKed > are the files that are being added to the ark hierarchy. > > If the value for a file that is added should be changed, please reply > with a better option. > > CONFIG_GPIO_HISI: > > Say Y or M here to build support for the HiSilicon GPIO controller > driver GPIO block. > This GPIO controller support double-edge interrupt and multi-core > concurrent access. > > Symbol: GPIO_HISI [=n] > Type : tristate > Defined at drivers/gpio/Kconfig:301 > Prompt: HiSilicon GPIO controller driver > Depends on: GPIOLIB [=y] && HAS_IOMEM [=y] && (ARM64 [=y] && ACPI > [=y] || COMPILE_TEST [=n]) > Location: > -> Device Drivers > -> GPIO Support (GPIOLIB [=y]) > -> Memory mapped GPIO drivers > Selects: GPIO_GENERIC [=m] && GPIOLIB_IRQCHIP [=y] > > --- > > Cc: Brian Masney <bmasney@redhat.com> > Cc: David Arcari <darcari@redhat.com> > Signed-off-by: Fedora Kernel Team <kernel-team@fedoraproject.org> > Hi, Unfortunately this is not something that I can review. We need someone from the ARM team to be added to the maintainer's list for gpio. Thanks, -DAremoved No CCs label
David Arcari darcari@redhat.com commented via email:
On 12/22/20 11:15 AM, GitLab Bridge on behalf of redhat-patchlab wrote: > From: redhat-patchlab on gitlab.com > > Hi, > > As part of the ongoing rebase effort, the following configuration > options need to be reviewed. > > As a reminder, the ARK configuration flow involves moving unreviewed > configuration options from the pending directory to the ark directory. > In the diff below, options are removed from the pending directory and > added to the ark hierarchy. The final options that need to be ACKed > are the files that are being added to the ark hierarchy. > > If the value for a file that is added should be changed, please reply > with a better option. > > CONFIG_GPIO_HISI: > > Say Y or M here to build support for the HiSilicon GPIO controller > driver GPIO block. > This GPIO controller support double-edge interrupt and multi-core > concurrent access. > > Symbol: GPIO_HISI [=n] > Type : tristate > Defined at drivers/gpio/Kconfig:301 > Prompt: HiSilicon GPIO controller driver > Depends on: GPIOLIB [=y] && HAS_IOMEM [=y] && (ARM64 [=y] && ACPI > [=y] || COMPILE_TEST [=n]) > Location: > -> Device Drivers > -> GPIO Support (GPIOLIB [=y]) > -> Memory mapped GPIO drivers > Selects: GPIO_GENERIC [=m] && GPIOLIB_IRQCHIP [=y] > > --- > > Cc: Brian Masney <bmasney@redhat.com> > Cc: David Arcari <darcari@redhat.com> > Signed-off-by: Fedora Kernel Team <kernel-team@fedoraproject.org> > Unfortunatley, I cannot help with this patchset. We need add a maintainer for AARCH64 for gpio. Thanks, -DA- Resolved by Don Zickus
This should be moved to .../generic/aarch64
- Last reply by Patrick Talbert
removed AcksNeedsReview label
added DependenciesOK label
added AcksNeedsReview label
ACK/NACK Summary: NeedsReview - Requires at least one ACK from the set(s) (bmasney@redhat.com, msalter@redhat.com).
Acked-by: Mark Salter msalter@redhat.com (via approve button)
