[redhat] New configs in drivers/dma-buf

Hi,

As part of the ongoing rebase effort, the following configuration options need to be reviewed.

As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.

If the value for a file that is added should be changed, please reply with a better option.

CONFIG_DMABUF_HEAPS_SYSTEM:

Choose this option to enable the system dmabuf heap. The system heap is backed by pages from the buddy allocator. If in doubt, say Y.

Symbol: DMABUF_HEAPS_SYSTEM [=n] Type : bool Defined at drivers/dma-buf/heaps/Kconfig:1 Prompt: DMA-BUF System Heap Depends on: DMABUF_HEAPS [=y] Location: -> Device Drivers -> DMABUF options -> DMA-BUF Userland Memory Heaps (DMABUF_HEAPS [=y])

---

Cc: Lyude Paul lyude@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org

added Configuration label

assigned to @prarit and unassigned @jeremycline

added No CCs label

added 1 commit

• 199934ce - New configs in drivers/dma-buf

Compare with previous version

Lyude Paul lyude@redhat.com commented via email:

Change this to Y

On Wed, 2020-09-30 at 13:37 +0000, GitLab Bridge on behalf of jeremycline wrote:
> From: Fedora Kernel Team <kernel-team@fedoraproject.org>
> 
> Hi,
> 
> As part of the ongoing rebase effort, the following configuration
> options need to be reviewed.
> 
> As a reminder, the ARK configuration flow involves moving unreviewed
> configuration options from the pending directory to the ark directory.
> In the diff below, options are removed from the pending directory and
> added to the ark hierarchy. The final options that need to be ACKed
> are the files that are being added to the ark hierarchy.
> 
> If the value for a file that is added should be changed, please reply
> with a better option.
> 
>  CONFIG_DMABUF_HEAPS_SYSTEM:
> 
>  Choose this option to enable the system dmabuf heap. The system heap
>  is backed by pages from the buddy allocator. If in doubt, say Y.
> 
>  Symbol: DMABUF_HEAPS_SYSTEM [=n]
>  Type  : bool
>  Defined at drivers/dma-buf/heaps/Kconfig:1
>    Prompt: DMA-BUF System Heap
>    Depends on: DMABUF_HEAPS [=y]
>    Location:
>      -> Device Drivers
>        -> DMABUF options
>          -> DMA-BUF Userland Memory Heaps (DMABUF_HEAPS [=y])
> 
> Cc: Lyude Paul <lyude@redhat.com>
> ---
>  .../common/generic/CONFIG_DMABUF_HEAPS_SYSTEM  |  1 +
>  .../generic/CONFIG_DMABUF_HEAPS_SYSTEM         | 18 ------------------
>  2 files changed, 1 insertion(+), 18 deletions(-)
>  create mode 100644 redhat/configs/common/generic/CONFIG_DMABUF_HEAPS_SYSTEM
>  delete mode 100644 redhat/configs/pending-
> common/generic/CONFIG_DMABUF_HEAPS_SYSTEM
> 
> diff --git a/redhat/configs/common/generic/CONFIG_DMABUF_HEAPS_SYSTEM
> b/redhat/configs/common/generic/CONFIG_DMABUF_HEAPS_SYSTEM
> new file mode 100644
> index 000000000000..0e816f5b8e09
> --- /dev/null
> +++ b/redhat/configs/common/generic/CONFIG_DMABUF_HEAPS_SYSTEM
> @@ -0,0 +1 @@
> +# CONFIG_DMABUF_HEAPS_SYSTEM is not set
> diff --git a/redhat/configs/pending-common/generic/CONFIG_DMABUF_HEAPS_SYSTEM
> b/redhat/configs/pending-common/generic/CONFIG_DMABUF_HEAPS_SYSTEM
> deleted file mode 100644
> index 0d3ac7684131..000000000000
> --- a/redhat/configs/pending-common/generic/CONFIG_DMABUF_HEAPS_SYSTEM
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -# CONFIG_DMABUF_HEAPS_SYSTEM:
> -# 
> -# Choose this option to enable the system dmabuf heap. The system heap
> -# is backed by pages from the buddy allocator. If in doubt, say Y.
> -# 
> -# Symbol: DMABUF_HEAPS_SYSTEM [=n]
> -# Type  : bool
> -# Defined at drivers/dma-buf/heaps/Kconfig:1
> -#   Prompt: DMA-BUF System Heap
> -#   Depends on: DMABUF_HEAPS [=y]
> -#   Location:
> -#     -> Device Drivers
> -#       -> DMABUF options
> -#         -> DMA-BUF Userland Memory Heaps (DMABUF_HEAPS [=y])
> -# 
> -# 
> -# 
> -# CONFIG_DMABUF_HEAPS_SYSTEM is not set

added 1 commit

• 70d36ba1 - Update CONFIG_DMABUF_HEAPS_SYSTEM

Compare with previous version

removed No CCs label

added AcksNeedsReview label

added External Contribution label

Hi! This is the friendly CKI test bot.

It appears that you are not a member of redhat/red-hat-ci-tools/kernel/cki-runs/trusted-pipelines. This means that the CI pipeline on your MR will fail. As getting testing is important, I'll be responsible for testing your changes. After every MR change, I'll start a small testing pipeline and link it here so you can follow the results. I'll also create and link a pipeline for hardware testing that the reviewers can start to get extra test coverage.

Testing pipeline status: Basic testing pipeline:

  https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki-runs/external-pipelines/-/pipelines/246926836 - failed

changed the description

Lyude Paul lyude@redhat.com commented via email:

Reviewed-by: Lyude Paul <lyude@redhat.com>

On Tue, 2021-01-26 at 11:18 +0000, cki-gitlab@redhat.com wrote:
> From: Patrick Talbert on gitlab.com
> https://gitlab.com/cki-project/kernel-ark/-/merge_requests/457#note_494070167
> 
> Hey Lyude,
> 
> I have updated the MR with your requested change. Please review!
> 
> All commits in this MR will be squashed upon merge.
> 
> Thank you,
> 
> Patrick
>

resolved all threads

merged

mentioned in commit f3ad9b01