Skip to content

phy: rockchip-inno-usb2: Return zero after otg sync

This fixes the following upstream bug: https://lore.kernel.org/linux-rockchip/9bb5e351-6ef3-94d7-92b8-009da91574db@arm.com/T/

The otg sync state patch reuses the ret variable, but fails to set it to zero after use. This leads to a situation when the otg port is in peripheral mode where the otg phy aborts halfway through setup. It also fails to account for a failure to register the extcon notifier. Fix this by using our own variable and skipping otg sync in case of failure.

Fixes: 8dc60f8d ("phy: rockchip-inno-usb2: Sync initial otg state") Reported-by: Markus Reichl m.reichl@fivetechno.de Reported-by: Michael Riesch michael.riesch@wolfvision.net Signed-off-by: Peter Geis pgwipeout@gmail.com Tested-by: Michael Riesch michael.riesch@wolfvision.net Tested-by: Markus Reichl m.reichl@fivetechno.de Reviewed-by: Samuel Holland samuel@sholland.org

Merge request reports

Loading