Skip to content

objtool: check: give big enough buffer for pv_ops

Justin M. Forbes requested to merge jmflinuxtx/kernel-ark:gcc12-1 into os-build

On gcc-12 build fails flagging possible buffer overflow:

check.c: In function 'validate_call':
check.c:2865:58: error: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 9 [-Werror=format-truncation=]
 2865 |                 snprintf(pvname, sizeof(pvname), "pv_ops[%d]", idx);
      |                                                          ^~

I think it's a valid warning:

static char pvname[16];
int idx;
...
idx = (rel->addend / sizeof(void *));
snprintf(pvname, sizeof(pvname), "pv_ops[%d]", idx);

we have only 7 chars for %d while it could take up to 9.

CC: Josh Poimboeuf jpoimboe@redhat.com CC: Peter Zijlstra peterz@infradead.org

Merge request reports