Config consolidation into common

This is the output of the 'evaluate_configs -j' run. Configs which were the same in both ark and fedora are consolidated to common. I have verified that this makes absolutely no changes to the generated config files, there is specifically no diff in redhat/configs/kernel-*.config files generated before the change and ones generated after.

Signed-off-by: Justin M. Forbes jforbes@fedoraproject.org

added DependenciesOK label

added Configuration label

requested review from @marcelo.leitner, @hertonrk-rh, @gnault, @linville-rh, @lxin.redhat, @jwilsonrh, @NefigTut, @crecklin, @atenart, @npache, @sdubroca, @ivecera, @darcari, @mstowe1, @eauger1, @jtoppins_redhat, @fwestpha, @baoquan_he, @LorenzoBianconi, @pabeni, @jmoyer1, @arozansk, @aclaudi, @psutter1, @egarver, @artem.savkov, @ddutile, @bmeneg, @prarit, @fleitner, @llong1, @bmasney, @liuhangbin, @rbriggs, @tohojo, @gtiwari1, @dcaratti, @raquini, @jsnitsel, @jbencrh, @alex.williamson, and @bnemeth

added AcksNeedsReview Acks::mmNeedsReview Acks::netNeedsReview labels

approved this merge request

added Acks::mmOK label and removed Acks::mmNeedsReview label

approved this merge request

Just as a side note, this is something we plan to run regularly. If the generated config files are 100% identical to the ones we get before the script run, do we really need to generate an MR and review every time or should they just be pushed?

"Just be pushed" makes sense to me, in that case.

I have no objection to just "push" it without an MR as long as there is no changed in generated config files.

Why is the option named -j?

approved this merge request

i would guess it is for "join".

approved this merge request

Couldn't we just make it so that introducing such duplicate configs fails the build (i.e. make dist-configs fails)? Or run evaluate_configs -j in the MR pipelines? That way new duplicates wouldn't even be introduced in the first place and no regular fixups would be needed.

Not exactly, without a lot more manual work. The problem is, new config items are introduced into both pending-fedora and pending-common. The MR is created to move pending-common to common, but it does not know how I am actually going to set it for Fedora. Something that fails configs could require I got back and re-evaluate any pending MRs every time I set a Fedora config.

approved this merge request

approved this merge request

added AcksOK Acks::netOK labels and removed AcksNeedsReview Acks::netNeedsReview labels

merged

mentioned in commit 9ca9a0c3

mentioned in merge request !1582 (merged)