Skip to content

Unpause shared secrets

Luke Addison requested to merge unpause-shared-secrets into master

This MR unpauses the shared-secrets Job to prevent Helm from hanging during install and upgrade.

The reason for this behaviour is that Helm will pause the shared-secrets Job on install and update (implemented here https://gitlab.com/charts/gitlab/merge_requests/435) and this Job has to complete before the rest of workloads are updated (due to the Helm pre-install/pre-update hook). Pausing the Job by default gives the operator the chance to pause all other workloads (implemented here) so that when when Helm applies the remaining changes after the shared-secrets Job has run successfully, no automatic updates will occur, giving the operator the chance to control an update (or just to unpause all the workloads again if no update is required).

This relies on https://gitlab.com/gitlab-org/distribution/gitlab-operator/merge_requests/5 and https://gitlab.com/charts/gitlab/merge_requests/435

Edited by Luke Addison

Merge request reports