Skip to content

Fix sources progressbar

Taslim Oseni requested to merge fix-sources-progressbar into develop

This MR addresses two issues I noticed:

  1. I observed that the old blue progress bar still faintly appears during webpage loading. Although it's not very noticeable, it briefly shows up for a second or two.

Screenshot_20240319_165503

The BrowserToolbar class doesn't allow for visibility toggles or direct references to the ProgressBar view, so I implemented an improved solution to hide the default ProgressBar. Instead of using the sources bar to block it out, I added a dedicated view that completely obscures the ProgressBar. Additionally, I tested thoroughly across various device densities to ensure consistent behavior.

  1. Addressing the first issue made me notice a difference in the update-speed between the old-blue progress bar and the new sources-progress bar. This discrepancy stemmed from differences in the refresh delays for each case. While the delay for fetching sources count is 1 second, the refresh delay for the original blue progress bar is only 200 ms. To fix this, I adjusted the sources-count fetch delay to 500 milliseconds. I think bringing it down to 200ms might introduce some performance issues.

Merge request reports