Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • F framework
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 422
    • Issues 422
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 15
    • Merge requests 15
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

GitLab 15.0 has launched! Please visit Breaking changes in 15.0 and 15.0 Removals to see which breaking changes may impact your workflow.

  • cdli
  • framework
  • Merge requests
  • !318

3D Viewer Integration

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mustafa Dhar requested to merge phoenix/feature/3dviewer into phoenix/develop Jun 14, 2021
  • Overview 34
  • Commits 21
  • Changes 32

Fixes

Adds 3D Viewer to CDLI by @msquare-2

Description

Added 3D Model Viewer for cuneiform tablets in (.PLY) format and adds various functionality for interacting with 3D Model.

Type of PR This PR is a feature.

Technicalities

Tests

To test this PR simply open the link with CDLI_NO added after ' / ' in URL.

For example:

http://127.0.0.1:2354/3dviewer/P215518

To test easy navigation feature for 3D viewer:

Open artifact view for any model, If it contains 3D data it should display a link to switch to the 3D viewer with the associated cuneiform tablet.

For example:

Open artifact view of tablet P215518, Now there will be a link "View in 3D" after the "View line art" link.

In the same way for an artifact view, which does not have 3D data should not have an option of "View in 3D". eg. http://127.0.0.1:2354/artifacts/384786

Screenshots

Artifact View for which 3D data is available:

View_in_3d

3D Viewer for tablet P215518:

3d_viewer_of_P215518

Checklist:

  • My pull request has a descriptive title (not a vague title like "Update index.md").
  • My pull request targets the phoenix/develop branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
Edited Jul 05, 2021 by Mustafa Dhar
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: phoenix/feature/3dviewer