Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • F framework
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 479
    • Issues 479
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 14
    • Merge requests 14
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • cdlicdli
  • framework
  • Merge requests
  • !147

Layout for AdvancedSearch and SearchSettings Page

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Samarth Sharma requested to merge phoenix/feature/search-f into phoenix/develop Jul 04, 2020
  • Overview 17
  • Commits 65
  • Pipelines 0
  • Changes 8

Fixes

Fixes for #48 (closed) and #37 (closed) by @RoLoDeXx

Description

This PR is regarding markup for SearchSettings page and AdvancedSearch page

Type of PR This PR is a feature.

Tests

Hop on to http://localhost:2354/AdvancedSearch and http://localhost:2354/SearchSettings

Design prototypes: https://app.zeplin.io/project/5cd250d2e18bd568686fa597

NOTE - Compile CSS first and do a hard reload on your browser

Screencasts

Screencast_from_Tuesday_07_July_2020_06_59_46__IST Screencast_from_Tuesday_07_July_2020_06_59_20__IST Checklist:

  • My pull request has a descriptive title (not a vague title like "Update index.md").
  • My pull request targets the phoenix/develop branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I tried running the project locally and verified that there are no visible errors.
Edited Jul 07, 2020 by Samarth Sharma
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: phoenix/feature/search-f