Skip to content

Design integration for search results.

Samarth Sharmarequested to merge
phoenix/feature/search-f into phoenix/develop

Fixes

Fixes for #50 (closed) , #51 (closed) , #52 (closed) and #238 (closed) (partially) by @RoLoDeXx

Description

This is the markup updates for search results page, it contains markup for compact view, full view and partially address checkpoints mentioned in #238 (closed) .

Type of PR This PR is a [improvement].

Technicalities

  • All the markup changes reside inside the app/cake/src/Template/Search/index.ctp
  • There are two ways to present search results Card and Table. View can be toggled using $LayoutType
  • $filterOptions contains the various filters for the sort by dropdown
  • $filterEntriesType is an array that contains show entries with filters for filter modal and filter sidebar
  • $ObjectFilters is an array that contains type of object filters for filter modal and filter sidebar
  • $TextualFilters is an array that contains type of text filters for filter modal and filter sidebar
  • $PublicationFilters is an array that contains type of Publication filters for filter modal and filter sidebar
  • $appliedFilters is an array that contains filters that are used in applied filters bar
  • $showFilterDiv is used to toggle between filter modal and filter sidebar.

PS - It's fair to note that every minute detail can't be addressed here, feel free to reach out to me anytime.

Tests

Visit the following link http://localhost:2354/search?CDLI1=1 (Compile the css and do a hard reload first)

Zeplin designs - https://zpl.io/2GGKPwm

Screenshots

Screencast_from_Monday_15_June_2020_05_40_40__IST

Screencast_from_Monday_15_June_2020_05_46_13__IST

Screencast_from_Monday_15_June_2020_05_48_18__IST

Screencast_from_Monday_15_June_2020_05_52_11__IST

Screenshot_from_2020-06-15_05-47-47

Checklist:

  • My pull request has a descriptive title (not a vague title like "Update index.md").
  • My pull request targets the phoenix/develop branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
Edited by Samarth Sharma

Merge request reports