Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • F framework
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 480
    • Issues 480
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 15
    • Merge requests 15
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • cdlicdli
  • framework
  • Merge requests
  • !126

Feature : Postings for highlights and news on the home page

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Émilie Pagé-Perron requested to merge phoenix/feature/postings-update into phoenix/develop Jun 13, 2020
  • Overview 24
  • Commits 52
  • Pipelines 0
  • Changes 24

I have deleted my branch and the PR, re-pushed and recreated a PR with proper branch name.

Description This PR contains both a helper to grab the main image of an artifact and required changes to display highlights and news from the database. It includes changed to the db, model, controllers and views.

You will need the sql files from #database_schema

Right now it pulls a limit of 6 items, we would have to order news per date and Maybe select highlights randomly. Have to see with @RoLoDeXx @amanbis and @amaaniqbal

@RoLoDeXx will fix the css for the images so don't mind their weird height.

@RoLoDeXx don't hesitate to change the home view as you like, I just wanted to provide functionality.

Type of PR This PR is a feature

Tests Visit the home page and see that you can see an image, a title and a body for highlights

Screenshots Screenshot_from_2020-06-13_11-38-49

Screenshot_from_2020-06-13_11-39-02 and news.

Checklist:

  • My pull request has a descriptive title (not a vague title like "Update index.md").
  • My pull request targets the phoenix/develop branch of the repository.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
Edited Jun 15, 2020 by Vedant Wakalkar
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: phoenix/feature/postings-update