... | @@ -20,7 +20,7 @@ The _known failure_ status for the new tests is removed, the new tests are re-ru |
... | @@ -20,7 +20,7 @@ The _known failure_ status for the new tests is removed, the new tests are re-ru |
|
The [Gitlab CI](https://gitlab.com/samba-team/devel/samba/pipelines) provides a convenient way to do this, although there are several other approaches.
|
|
The [Gitlab CI](https://gitlab.com/samba-team/devel/samba/pipelines) provides a convenient way to do this, although there are several other approaches.
|
|
* The developer should end up with a coherent set of patches that add the new functionality, along with tests that prove the new functionality works correctly.
|
|
* The developer should end up with a coherent set of patches that add the new functionality, along with tests that prove the new functionality works correctly.
|
|
They then send the patch-set to the [samba-technical mailing-list](https://lists.samba.org/mailman/listinfo/samba-technical) for review.
|
|
They then send the patch-set to the [samba-technical mailing-list](https://lists.samba.org/mailman/listinfo/samba-technical) for review.
|
|
* The code is reviewed by a [Samba Team members](https://www.samba.org/samba/team).
|
|
* The code is reviewed by [Samba Team members](https://www.samba.org/samba/team).
|
|
While any developer can potentially contribute changes to the Samba codebase,
|
|
While any developer can potentially contribute changes to the Samba codebase,
|
|
only Samba Team members have the access rights to actually deliver code changes to the master code branch.
|
|
only Samba Team members have the access rights to actually deliver code changes to the master code branch.
|
|
Usually the reviewers provide some feedback on how the patches could be further improved.
|
|
Usually the reviewers provide some feedback on how the patches could be further improved.
|
... | @@ -80,9 +80,10 @@ More work could be done to investigate these intermittent test failures and fix |
... | @@ -80,9 +80,10 @@ More work could be done to investigate these intermittent test failures and fix |
|
|
|
|
|
## Code Review
|
|
## Code Review
|
|
|
|
|
|
All Samba code changes must be reviewed by another Samba Team Member before they can be delivered.
|
|
All Samba code changes written by a Samba Team member must be reviewed by
|
|
Code from someone outside the team must be reviewed by two Samba Team members.
|
|
another Samba Team member before they can be delivered. Code from someone
|
|
Once the reviewer is happy, a `Reviewed-by:` tag is added to each git commit.
|
|
outside the team must be reviewed by two Samba Team members. Once the reviewer
|
|
|
|
is happy, a `Reviewed-by:` tag is added to each git commit.
|
|
|
|
|
|
The [Samba Code Review policy](https://wiki.samba.org/index.php/CodeReview) outlines the review process in more detail.
|
|
The [Samba Code Review policy](https://wiki.samba.org/index.php/CodeReview) outlines the review process in more detail.
|
|
Samba has a [guide for new developers](https://wiki.samba.org/index.php/Contribute#How_to_Provide_C_Patches_for_Samba),
|
|
Samba has a [guide for new developers](https://wiki.samba.org/index.php/Contribute#How_to_Provide_C_Patches_for_Samba),
|
... | | ... | |