Skip to content

Feature: Add dynamic month label

Liv M requested to merge livgm/drip:feature/month-tag into main

Why this change?

Currently, it is very difficult to see which month you're currently looking at in chart view. The option of having the month tag replacing the first of every month seems to cause issues (#661) as well and is not intuitive.

Description

Instead of the plain "DATE" there is now a three letter month tag to the left of the symptom chart view that updates when scrolling.

I have tested this MR:

  • tested this PR on iOS simulator/physical device,
  • tested this PR on Android simulator/physical device,
  • ran e2e tests.

Steps to Test or Reproduce

Scroll to the left until you hit a different month. The label should update accordingly.

Reviewing

Here's what I am looking for feedback on in particular: Is the tag too slow to update? It feels fine when testing on the simulator. When should the switch happen? If the 1st of the month is in the middle of the screen or to the right?

In addition:

Could not test run Android tests and e2e tests. Will update here when done!

Merge request reports