Skip to content

Draft: fahrenheit: Adding unit selection to the settings menu.

Larry Dewey requested to merge TheSilentDrifter/drip:fahrenheit into main

Why this change?

This is to address the lack of imperial units for temperature.

Closes ticket #628 #528 #462

Description

I have tested this MR:

  • tested this PR on iOS simulator/physical device, (I don't have one)
  • tested this PR on Android simulator/physical device,
  • ran e2e tests.

A few sentences describing the overall goals of the pull request's commits.

The goal of this commit is to add the capability of enabling imperial measurements for temperatures.

Steps to Test or Reproduce

Outline the steps to test or reproduce the MR here.

Reviewing

Here's what I am looking for feedback on in particular:

  • additional testing on specific type of the devices,
  • feedback on specific part of the code,
  • review of practices (I am not a react developer).
Edited by Larry Dewey

Merge request reports