Skip to content

Resolve "Bug: Temperature value cannot be entered with comma"

Lisa requested to merge 540-Temperature-value-cannot-be-entered-with-comma into master

Why this change?

  • On iOS, the numeric keyboard only allows to enter a comma
  • Our temperature input field only allows numbers separated by dots

Description

  • Replace comma in input with dot
  • Additionally ensured that users can removed every number they input --> previously, it was only possible to remove digits but the last one would remain in the input field

Reviewing

Here's what I am looking for feedback on in particular:

Test on iOS

  1. Open dialog to edit temperature with no previous temperature values and no value for the day, enter temperature and press save button
  • temperature should be saved
  1. Open dialog with previous temperature available
  • value should be prefilled with the value of the last day for which a temperature was entered
  • When clicking save button, prefilled value should be saved a temperature for that day
  1. Open dialog for a day for which a temperature was saved
  • value should be prefilled with the value that was previously saved
  • When clicking save button, prefilled value should be saved a temperature for that day

In addition:

  • Refactored temperature component to functional component
  • Pre-filled the input with either data from props or data from previous temperatares that a user had saved
    • it is not required anymore to tap on the input field once to be able to save the data

Closes #540 (closed)

Merge request reports