Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
trains-and-things
trains-and-things
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 30
    • Issues 30
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Requirements
    • Requirements
    • List
  • Operations
    • Operations
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • bitshift-public
  • trains-and-thingstrains-and-things
  • Issues
  • #103

Closed
Open
Opened Feb 20, 2020 by Fabian Mathews@supaguOwner

Camera zoom into terrain slides forwards

Following on from #90 (closed), when you zoom into the terrain, it drives the camera forwards. It is very annoying!

maybe we should try normalizing zoom height from 1 (the highest point) to 0 (the mouse cursor height), instead of 0 being at water level.

we need to stop the camera sliding forwards when we zoom into terrain. then zooming out becomes buggy until the camera gets off the ground.

most importantly, this doesn't work with a variable frame rate... see australia! might need to account for the frame rate when computing the delta time...

I had to open a Godot feature proposal: https://github.com/godotengine/godot-proposals/issues/552

FOR 0.3, if i implement the same code I did for linux in input event patch, then that should do for 0.3.... this means building and debugging on windows!

I got stuck, I cant do a windows build in windows for the current engine version, so tried upgrading to the latest engine (engine_upgrade branch) but got stuck, so can't add OS timing for windows.

Will have to ship with janky zoom on windows for low FPS... try again when this is fixed: https://github.com/godotengine/godot/issues/36804

also https://github.com/godotengine/godot/issues/36444 is hampering the engine_upgrade

with the input timing this bug isnt as bad, it only really an issue when FPS is low on windows now.

Edited Mar 13, 2020 by Fabian Mathews
Assignee
Assign to
0.5
Milestone
0.5
Assign milestone
Time tracking
None
Due date
None
Reference: bitshift-io/trains-and-things#103