Skip to content

Fix ODR violation leading to subtle build error on Fedora

Calin Culianu requested to merge cculianu/bitcoin-cash-node:fix_rpm_build_issue into master

Summary

See the description in issue #176 (closed). This closes #176 (closed). The basic jist of it is that we inherited some questionable code from Core ABC in which mapOrphanTransactions was declared inconsistently and this caused newer GCC to emit bad code and/or complain.

The fix is to actually declare things only once in 1 place and not have such footguns waiting to go off in the codebase. See diff.

Test Plan

  • ninja check check-functional
Edited by Calin Culianu

Merge request reports