Skip to content

Nit to timedata.cpp: break out of loop when we get an answer

Calin Culianu requested to merge cculianu/bitcoin-cash-node:timedata_nit_break_from_loop into master

Summary

Until we address #132, we should at least make sure the code in timedata.cpp is kosher. This commit is a nit.

The timedata.cpp code is ancient -- it dates back to the original code from satoshi 0.1.0, initial release. It's been modified since to use a ranged for-loop but the modification forgot to break out of the loop early. There is no reason to keep looping once an answer is determined to the fMatch flag.

Test summary

  • review change
  • ninja all check

This code introduces no semantic or other changes. It merely aborts a loop that doesn't need to keep looping once it sets the flag.

Merge request reports