Skip to content

Remove deprecated boost::basename method.

Marius Kjeldahl requested to merge mariusk/bitcoin-cash-node:master into master

Summary

Added by Calin: Boost removed boost::basename in 1.85.

Fixes build issue on Mac. Looks like boost::basename is deprecated. Found suggested workaround here, which I implemented and tested. After that it built and ran fine on my system, but I have no idea if this code is actually being used successfully or not:

https://github.com/Project-OSRM/osrm-backend/commit/dea12779cf6f7ad01e2daf602903c3e0871919a0

Tested on recently updated macOS Sonoma 14.5 using Homebrew installed boost version 1.85.0.

Test Plan

Added by Calin

Try this on both Boost 1.58+ and also Boost 1.85 -- both should compile OK. Note the changed line of code is only for an advisory name and this is not critical.

ninja all check-all

Note also that on Boost 1.85 you will still get compilation errors so you have to build with -DBUILD_BITCOIN_WALLET=OFF. A follow-up MR will handle the remaining changes.

Added by Calin: This is a partial backport of: https://reviews.bitcoinabc.org/D7362

Edited by Calin Culianu

Merge request reports