Rename "ForkID" functions and variables to "Fork"
This is on top of !1587 (merged), and should be reviewed after it is merged to avoid confusion in the diffs.
This MR ddresses #432 (closed), and specifically this suggestion: #432 (comment 1003264085)
- Rename
withForkId function to
withFork` - Rename
hasForkId function to
hasFork` - Rename misc forkid-related vars to use "fork" rather than "forkid"
- Update comments relating to "forkid" to describe it as "fork sig", or just "fork", as appropriate.
The SIGHASH_FORKID
, SCRIPT_ENABLE_SIGHASH_FORKID
and bitcoinconsensus_SCRIPT_ENABLE_SIGHASH_FORKID
flag names are retained, as is the FORKID
shorthand in RPC.
This is a pure refactor - no functional changes.
Test plan
ninja check-all