Skip to content

depends: Fix compile error for Qt 5.9.7 when using newer GCC 11.2+

Calin Culianu requested to merge cculianu/bitcoin-cash-node:qt_fix_numeric_limits_compile_error into master

This MR is an alternative to closing #417 (closed) before !1523 (merged) is merged (which also fixes #417 (closed) due to using newer Qt).

Summary

This MR fixes a compile error encountered on newer Ubuntu when building the (now ancient) Qt 5.9.7 via depends. The issue was observed on Ubuntu 21.10 and 22.04, where a missing include caused compile errors.

We fix the error by adding a patch that does a #include <limits> for the offending file.

Fixes issue #417 (closed)

Test Plan

  1. Reproduce the problem on master by using either Ubuntu 21.10 or Ubuntu 22.04 (or a system with GCC 11.2+):
  • cd depends/ && make build-linux64
  • You should see it fail when it gets to building Qt with an error log similar to what is seen in #417 (closed).
  1. Switch to this commit and try it again:
  • cd depends/ && make build-linux64
  • You should see it succeed and finish building all depends.

Merge request reports