Skip to content

[build] Add missing dependency for bitcoin-wallet to functional test build target

freetrader requested to merge freetrader/bitcoin-cash-node:fix/missing_dep_for_bitcoin-wallet_in_test into master

Closes #365 (closed).

Functional tests used to be callable by running ninja check-functional without requiring ninja all to be explicitly called first.

This seems a sensible user experience to retain. (Rationale is that all build targets should include their full dependencies)

Test plan:

  • rm -rf build && mkdir build && cd build && cmake -DCMAKE_BUILD_TYPE=Release -GNinja .. && ninja check-functional

Expected outcomes:

  • without this patch, a failure only in tool-wallet.py
  • with this patch, all basic functional tests pass

Merge request reports