Skip to content

Remove -tachyonactivationtime from CLI args & consensus rules

Calin Culianu requested to merge cculianu/bitcoin-cash-node:mempool/rm_tachyonactivationtime into master

Note: This is an MR built on top of !1184 (merged) and is a part of a series that wants to complete the tasks for post-tachyon work outlined in #295 (closed).

Summary

Since this upgrade was relay-rules-only, the activation time is no longer relevant for validating the blockchain itself, thus the time should no longer be tracked or stored.

Additionally, since the activation logic was removed by a previous MR, nothing was using this value in the codebase, and it was just dead code.

Summary of changes:

  • removed the CLI arg -tachyonactivationtime
  • removed the function IsTachyonEnabled in activation.cpp since nothing other than unit tests was calling it.
  • removed the unit test that called this function since it is not needed
  • removed tachyonActivationTime from the consensus params
  • left comments in place about what the activation time once was where the old data used to live.

Test Plan

ninja all check-all

Edited by Calin Culianu

Merge request reports