Skip to content

Explicit QString conversion of QLocale groupSeparator

BigBlockIfTrue requested to merge BigBlockIfTrue/bitcoin-cash-node:bug/qstring-groupseparator into master

String conversion is recommended per https://doc.qt.io/qt-5/qlocale.html#groupSeparator

However, apparently some Qt versions don't automatically promote QChar to QString when comparing to a C++ string literal, so we should make the QString conversion explicit.

Test plan: ninja check

Merge request reports