Skip to content

DSProof: Minor fixup to questionable use of incrementOrphans()

Calin Culianu requested to merge cculianu/bitcoin-cash-node:dsproof_fix_issue_265 into master

Summary

This closes issue #265 (closed).

It's not entirely clear whether boost multi-indexed containers support deletion while modifying a container entry. Even of they do, it's strange to delete from the container while modifying an entry.

The code is cleaner with this commit -- where we increment the counter first then modify the entry afterward. It also makes the lambda simpler and everything simpler to do it this way.

Test Plan

No external observable changes should be introduced.

  • ninja all check-all

Closes #265 (closed)

Merge request reports