Skip to content

miner: Remove use of CPFP in CreateNewBlock

Dagur Valberg Johannsson requested to merge dagurval/bitcoin-cash-node:cpfp-miner into master

This removes the use of CPFP during block generation. Instead, transactions are evaluated for block inclusion on individual bases by modified fee rate.

Notably, this improves the performance of block generation and benchmark tests have been adjusted to keep within the ~5 second window as follows:

  • Generate block with 50 chained 1-input-1-output transactions from 800 iterations to 3000
  • Generate block with 500 chained 1-input-1-output transactions from 8 iterations to 300

Pulled out of @jtoomim's cpfp-nuke branch.

Test plan

ninja check-bitcoin check-functional

Edited by Dagur Valberg Johannsson

Merge request reports