Row Comments Frontend -> Row Comments Final Branch
Merge Request Checklist
Testing Notes
- Can still comment on a row with 1000+ rows and scroll through it etc
- Pasting/cutting correctly expands and shrinks the row comment box
- The trash modal infinite scroll still works well and its new end line lines up nicely
- A no comments placeholder is shown only when the server returns 0 total comments
- Comments are sorted correctly by created_on date time
Done
-
changelog.md has been updated if required -
Quality Standards are met -
The UI/UX has been updated following UI Style Guide -
The redoc API pages have been updated for any REST API changes -
The per database user API docs page has been updated for any REST API changes made to endpoints which can be accessed via a user created token -
Has performance been considered and tested when appropriate? Ideally Baserow should be performant when working with hundreds of thousands of rows -
New/Changed Premium features are separated correctly in the premium folder
Not Required
-
Documentation has been updated -
There are tests for and it has been checked that any changed/new django ORM code is sensible, doesn't perform N queries and that table models are not generated needlessly or generated with all columns when only a few are needed.
Closes #539 (closed)
Edited by Nigel Gott