Skip to content

Resolve "URL validation of the frontend does not match the validation of the backend"

Merge Request Checklist

  • changelog.md has been updated if required
  • Documentation has been updated
  • Quality Standards are met
  • The UI/UX has been updated following UI Style Guide
  • The redoc API pages have been updated for any REST API changes
  • The per database user API docs page has been updated for any REST API changes made to endpoints which can be accessed via a user created token
  • Has performance been considered and tested when appropriate? Ideally Baserow should be performant when working with hundreds of thousands of rows
  • New/Changed Premium features are separated correctly in the premium folder
  • There are tests for and it has been checked that any changed/new django ORM code is sensible, doesn't perform N queries and that table models are not generated needlessly or generated with all columns when only a few are needed.

Closes #485 (closed) and #377 (closed)

Changes

  • This merge request makes the URL field more lenient. We want to accept as much URLS as possible because it could otherwise be experienced as annoying by users if their value doesn't validate. The web-frontend now also uses the same regex as the backend to keep the validation consistent.

Testing

  • Every URL should be accepted in the field.
  • Because I refactored a part that is also related to the email and phone field, they must also be checked. Make sure that the same column type in postgres is created there.
  • The validation should be exactly the same in the backend as in the web-frontend.
Edited by Bram Wiepjes

Merge request reports