Fix date filter input
What is in this MR
- E.g. a short explanation of what this MR does.
How to test this MR
- E.g. a short series of steps on how to test the features/bug fixes in this MR.
Merge Request Checklist
-
A changelog entry has been created if required. -
New/updated Premium/Enterprise features are separated correctly in the premium or enterprise folder -
The latest Chrome and Firefox have been used to test any new frontend features -
Documentation has been updated -
Quality Standards are met -
Performance: tables are still fast with 100k+ rows, 100+ field tables -
The redoc API pages have been updated for any REST API changes -
Our custom API docs are updated for changes to endpoints accessed via api tokens -
The UI/UX has been updated following UI Style Guide
Closes #2945 (closed)
Merge request reports
Activity
added database label
assigned to @stribny
requested review from @_dvd
added MRready for review ⭐ label
182 181 } 183 182 184 183 if (newDate.isValid()) { 185 this.setCopy(newDate.format('YYYY-MM-DD'), sender) 184 const dateString = newDate.format('YYYY-MM-DD') 185 this.setCopy(this.prepareValue(dateString), sender) I agree the
setValue
function is weird because is not actually setting the value, but just the copy. What we have to do here is basically:this.copy = value this.delayedUpdate(value, true)
That's the reason why I suggested to use
setValue
, but if it looks a bit less convoluted, we can explicitly set the copy and call the delayedUpdate. Either ways is fine with meEdited by Davide Silvestrichanged this line in version 2 of the diff
added MRreviewing 🔍 label and removed MRready for review ⭐ label
added MRunresolved feedback 💬 label and removed MRreviewing 🔍 label
- Resolved by Davide Silvestri
Should we also hide/don't render the
dateContext
ifselectedOperator?
hasDateInputValue` is not true?
added MRready for review ⭐ label and removed MRunresolved feedback 💬 label
added MRcan be merged ✅ label and removed MRready for review ⭐ label
enabled an automatic merge when all merge checks for 1300cb85 pass
mentioned in commit becc8016
mentioned in merge request !2968 (merged)