Resolve "Previous actions cannot be reused in Open Page actions"
What is in this MR
When the LinkNavigationSelectionForm
is being used in an Open Page
action, it's not allowing the formula inputs to use the 'Previous action' provider, probably because it's re-usable in a few forms that don't take actions into account.
In this MR we:
- Make
OpenPageWorkflowActionForm
pass its injecteddataProvidersAllowed
(provided down fromWorkflowAction
) intoLinkNavigationSelectionForm
, so that theOpen Page
action form can have access to the 'Previous action' provider. - Tweak
LinkNavigationSelectionForm
so that it can not optionally receive an array of allowed providers (so 1 can happen). If no array is provided, we default toDATA_PROVIDERS_ALLOWED_ELEMENTS
. - Tweak
NotificationWorkflowActionForm
so that it usesInjectedFormulaInputGroup
, like other workflow action forms, so they're consistent.
How to test this MR
- Create a link element, confirm the data providers in the form are correct and working.
- Create a table element with
type=link
column, confirm the data providers in the form are correct and working. - Add a button element, give it the following actions:
- Create row
- Open Page
- Confirm we now do have access to the Create Row action as a 'Previous action'.
- Notification
- Confirm we still do have access to the Create Row action as a 'Previous action'.
Merge Request Checklist
-
A changelog entry has been created if required. -
New/updated Premium/Enterprise features are separated correctly in the premium or enterprise folder -
The latest Chrome and Firefox have been used to test any new frontend features -
Documentation has been updated -
Quality Standards are met -
Performance: tables are still fast with 100k+ rows, 100+ field tables -
The redoc API pages have been updated for any REST API changes -
Our custom API docs are updated for changes to endpoints accessed via api tokens -
The UI/UX has been updated following UI Style Guide
Closes #2707 (closed)
Edited by Peter Evans