Resolve "Allow service filters which don't use ViewFilterTypeText/ViewFilterTypeNumber to support formulas."
requested to merge 2317-allow-service-filters-which-don-t-use-viewfiltertypetext-viewfiltertypenumber-to-support into develop
What is in this MR
This MR follows !2076 (merged), which introduced service filter formulas if the view filter component was either ViewFilterTypeText
or ViewFilterTypeNumber
.
In this MR, all filter types are now supported. When a filter is added, it will still default to the view filter type's getInputComponent
, but we now have a formula icon next to it:
When this formula icon is clicked, we swap the default input component for our InjectedFormulaInputGroup
and let users choose a page parameter as the value:
How to test this MR
- Create a page with page parameters.
- Create a new list data source.
- Add a new table element, connected to our new list data source.
- In the data source play around with creating filters, using their default component or the formula input.
Merge Request Checklist
-
changelog.md has been updated if required. -
New/updated Premium/Enterprise features are separated correctly in the premium or enterprise folder -
The latest Chrome and Firefox have been used to test any new frontend features -
Documentation has been updated -
Quality Standards are met -
Performance: tables are still fast with 100k+ rows, 100+ field tables -
The redoc API pages have been updated for any REST API changes -
Our custom API docs are updated for changes to endpoints accessed via api tokens -
The UI/UX has been updated following UI Style Guide
Closes #2317 (closed)
Edited by Peter Evans