Skip to content

Resolve "Improve Table element: improve link field type."

What is in this MR

This MR makes link-type fields in an AB table element possible to toggle between their navigation type (custom/page) in the same way that link elements do.

Things to be aware of

  1. There have been heavy changes to how element URL resolution happens, so be sure to try different link navigation choices!
  2. In LinkFieldForm I copied many of the components from LinkElementForm. In an ideal world, I'd like to make both of those components re-use a new "link selection" component to keep them dryer, but I think it's best to get what has been built so far reviewed before going down that path.

How to test this MR

LinkField

  • Add a ListRows service to your data sources.
  • Add a table element to your page, use the newly created data source.
  • Add four fields:
    • Field 1: Navigate to: a page with no page parameters.
    • Field 2: Navigate to: a page with one or more page parameters. Ideally two, one numeric and one text.
    • Field 3: Navigate to: a custom URL of your choosing.
    • Field 4: Navigate to: a blank custom URL.
  • Now preview your page and confirm that the link URLs match what the field was setup to do.

LinkElement

  • Add a LinkElement to your page.
  • Manually try the four permutations in the steps listed in LinkField.
  • Sanity check that still works as well.

Merge Request Checklist

  • changelog.md has been updated if required.
  • New/updated Premium/Enterprise features are separated correctly in the premium or enterprise folder
  • The latest Chrome and Firefox have been used to test any new frontend features
  • Documentation has been updated
  • Quality Standards are met
  • Performance: tables are still fast with 100k+ rows, 100+ field tables
  • The redoc API pages have been updated for any REST API changes
  • Our custom API docs are updated for changes to endpoints accessed via api tokens
  • The UI/UX has been updated following UI Style Guide

Closes #2215 (closed)

Edited by Peter Evans

Merge request reports